hey vex can u teach me kinda how to make it so the trigger spells make a shape plz teach me
Comments
28
thanks Vex, yeah i made it before i know about memory leaks, now i get it.
- Many memory leaks, specially Location Leaks.
- Charm Arrow is Abusable as hell because it uses the A unit is attacked event which happens before the unit attack, you can order it to attack, then stop then attack, and you can charm any unit in 2 seconds.
- Horrible GUI like structures
No need for many bugs, but even so you could have used a function to return all the buff raws, because people would like to have that spell for 4 levels perhaps?
- Charm Arrow is Abusable as hell because it uses the A unit is attacked event which happens before the unit attack, you can order it to attack, then stop then attack, and you can charm any unit in 2 seconds.
- Horrible GUI like structures
function BuffCond takes nothing returns boolean
if ( ( UnitHasBuffBJ(GetAttackedUnitBJ(), RawBuffLv1()) == true ) or ( UnitHasBuffBJ(GetAttackedUnitBJ(), RawBuffLv2()) == true ) or ( UnitHasBuffBJ(GetAttackedUnitBJ(), RawBuffLv3()) == true ) ) then
return true
endif
return false
endfunction
//could be
function BuffCond takes nothing returns boolean
return (GetUnitAbilityLevel(GetTriggerUnit(),RawBuff())>0)
endfunction
No need for many bugs, but even so you could have used a function to return all the buff raws, because people would like to have that spell for 4 levels perhaps?
OMG THAT PIC IS SO AWSOME 5/5
ROFLCOPTER
ROFLCOPTER
Yes Vex is a pro indeed. Just sad for wc3s' spells secion he leaved..
@Nantuko.. Funny, I've always used the shortest names as possible since I'm the most lazy person north of the Tropic of Cancer
.
@Nantuko.. Funny, I've always used the shortest names as possible since I'm the most lazy person north of the Tropic of Cancer
.
Leopard... I didn't know that Vex made a JASS tutorial. Could I see it as well? I'm curious to see what he did. After all, he is a pro!
~Daelin
yes vex made a jass tutor it is @ www.wc3jass.com, here is the link http://www.wc3jass.com/viewtopic.php?t=2039
Leopard... I didn't know that Vex made a JASS tutorial. Could I see it as well? I'm curious to see what he did. After all, he is a pro!
~Daelin
~Daelin
About variable name, i just want people easy to read my code, instead of just "DamageTarget(a,b,c,...)"
i used to put proper variable names,but for the variable is the best to be with the less chars possible,as some guys (dont remember who
,some @ wc3jass.com ) found that variable names affect the game....so
local unit u=GetTriggerUnit()
local effect e=AddSpecialEffect(bla bla bla)
//Is better than
local unit spellcaster=GetTriggerUnit()
local effect LightningFx=AddSpecial...
And yes the spells are well done,Leopard seems to be a talented Spellmaker
His star design is different from Daelin's, though this has been pointed out already.
I like Seal of Blood. The other two spells, however, aren't as original. Though, Celestial Star does have nice effects
I like Seal of Blood. The other two spells, however, aren't as original. Though, Celestial Star does have nice effects
Ok... I prefer comments for that, but it's your spell, your choise .
.Thx Blade.dk (without 2 
). I know about that way to set variable value upon variable initialization. That just my habit when coding on another language. 
About variable name, i just want people easy to read my code, instead of just "DamageTarget(a,b,c,...)" something like that.
). I know about that way to set variable value upon variable initialization. That just my habit when coding on another language. About variable name, i just want people easy to read my code, instead of just "DamageTarget(a,b,c,...)" something like that.
Leopard I looked closer at your code.. And you can set the values when you declare the locals like this
Oh, and just a tip: Jass gets slower if the function and variables names are longer. Don't think about the functions, it's a mess to make short function names and remember them.. But making the names of the locals shorter shouldn't be that difficult ..
And please forget that "2" at the end of my name, I'm getting sick of that it's only there because the site is bugged..
Oh, and your Jass are a bit leaky, but thats ok when you're new, you'll learn to remove the leaks as time goes.. I'm expecting a lot of good Jass spells and script from you in the future .
Blade
local unit u = GetTriggerUnit()Oh, and just a tip: Jass gets slower if the function and variables names are longer. Don't think about the functions, it's a mess to make short function names and remember them.. But making the names of the locals shorter shouldn't be that difficult
..And please forget that "2" at the end of my name, I'm getting sick of that it's only there because the site is bugged..
Oh, and your Jass are a bit leaky, but thats ok when you're new, you'll learn to remove the leaks as time goes.. I'm expecting a lot of good Jass spells and script from you in the future
.Blade
Thank you every one
@Blade.dk2 : yeah, actually i have inspiration from many spells, i've downloaded many Daelin's and Vex's stuffs and open those JASS thing, and try to learn from them. it would be better to me instead reading boring tutorial, lol. That's the way i learn JASS. Btw, thanks for your tutor Vex. I read little part on your tutorial, but, geezz.. your API! That seriously help!
@Cazat: make sure the 'Charm Arrow' trigger position is above 'Charm Arrow Effect' trigger. That means, all raw codes function on 'Charm Arrow' executed first, coz 'Charm Arrow Effect' use this function.
@Blade.dk2 : yeah, actually i have inspiration from many spells, i've downloaded many Daelin's and Vex's stuffs and open those JASS thing, and try to learn from them. it would be better to me instead reading boring tutorial, lol. That's the way i learn JASS. Btw, thanks for your tutor Vex. I read little part on your tutorial
, but, geezz.. your API! That seriously help!@Cazat: make sure the 'Charm Arrow' trigger position is above 'Charm Arrow Effect' trigger. That means, all raw codes function on 'Charm Arrow' executed first, coz 'Charm Arrow Effect' use this function.
Very nice indeed Leopard! You're one of the < 8 people who can take things serious and make nice stuff .. And agreed with Daeling we can trust you .. This is very nice and NOT stolen from his star shapes, but you got the inspiration from Daelin's Holy Spells pack, rigth? (Nothing's wrong with that, we all got ideas from some each other ). I would rate it high, if it wasn't because I'm against the rating system ..
Cazat: handle is the type which extends all other types except code, string, real, boolean and integer. When we use H2I we convert the handle (unit, timer, whatever it might be) to an unique integer. We converts the integer to a string and that is the categoty we saves either a real, string integer, boolean or handle (again converted to integer) in with the name. The reason we use a global gamecache variable is that we need a gamecache, and InitGameCache() aren't good to use all the times since it's leaky. Hopefully that helped you .
Oh, and once again nice spells Leopard And especially to see something in Jass from you .
.. And agreed with Daeling we can trust you .. This is very nice and NOT stolen from his star shapes, but you got the inspiration from Daelin's Holy Spells pack, rigth? (Nothing's wrong with that, we all got ideas from some each other ). I would rate it high, if it wasn't because I'm against the rating system ..Cazat: handle is the type which extends all other types except code, string, real, boolean and integer. When we use H2I we convert the handle (unit, timer, whatever it might be) to an unique integer. We converts the integer to a string and that is the categoty we saves either a real, string integer, boolean or handle (again converted to integer) in with the name. The reason we use a global gamecache variable is that we need a gamecache, and InitGameCache() aren't good to use all the times since it's leaky. Hopefully that helped you
.Oh, and once again nice spells Leopard
And especially to see something in Jass from you .
Maybe it reminds u the Star Shapes v1.1, Nabzo. But i know this is not a copy from it. Compare'em.
Star Looks very familiar and great spells 5/5
is handle vars a different type of variable? coz i created the same global vars (that 'gamecache' var) as in the spell map, also the custom scripts...but the errors came up...
leopard said must make all the global vars, but not handle vars. or is handle vars juz dat custom script?? i hav no idea...
leopard said must make all the global vars, but not handle vars. or is handle vars juz dat custom script?? i hav no idea...
I didn't downloaded the spells but if it needs gamecache creating it probably needs handler vars. Maybe you need to add Handler Vars to your map script (import tutorial).
i got some trouble importing ur spell, i copied the abilities, the dummy, the custom script and 2 triggers for charm arrow; i also made the gamecache variable! but i cant save my map afterwards, it comes up with loads of errors for functions nd stuff 
...well, why i could never successfully applying a jazz spell?! dat really troubles me.
plz help me!
btw, i also changed the raw codes
...well, why i could never successfully applying a jazz spell?! dat really troubles me.plz help me!
btw, i also changed the raw codes
Don't worry about Star System stuff guys... Leopard would never steal and besides, I know my sistem. And yes, his star is very inteligent made. However, I won't do further comments and I will check the spells only after the deadline!
~Daelin
And yes, his star is very inteligent made. However, I won't do further comments and I will check the spells only after the deadline! ~Daelin
thanx man, u did my charm arrow! although i'm currently doin my version, i found urs is smoother, so i will juz use urs then, great job!
although i'm currently doin my version, i found urs is smoother, so i will juz use urs then, great job!Thanks frostroll and Ilama.
Dash is the spell by request on spell forum, so i made it like what are expected.
No matter if someone doesn't look at it, bcoz i'm proud of it
Dash is the spell by request on spell forum, so i made it like what are expected.
No matter if someone doesn't look at it, bcoz i'm proud of it
Wow!! Good spells Leopard. I havent seen u make high-quality spells long time ago (I didnt liked the Dash spell much, too simple). 
By the way, your spells are the best ones I've ever downloaded (especially Icicle Catastrophe, an ultimate frost spell at last!!!)Stay cool!!!!!
NO AmadiTheGreat, it is NOT Daelin's Shape! Look at the screenshot, my 8-star is more like 8 triangle with 8 different angle direction. BUT, Daelin's Shape for 8-star is double rectangle that stack together but with defferent angle direction. You can download daelin's and compare the shape with mine. Or just compare the code!
In easiest way my 8-star(even star) not like Daelin's even star template. But more like his odd star, and of course it DIFFERENT! becoz i make the even star to look like an odd star.
In easiest way my 8-star(even star) not like Daelin's even star template. But more like his odd star, and of course it DIFFERENT! becoz i make the even star to look like an odd star.
gj leopard 5/5 very usefull i liked the celestial star spell the best
I think that celestial star uses same system as daelin's star spells. If thats the case the rules for arcane competition says not copies from older spells and no usement of spell systems made by different people.
Still the spells are nice, i give them 4/5
The star shape isn't something hard to make. You just take the points on two circles anf connect them. If this was stolen from Star Shapes, Leopard would be disqualified.
I think that celestial star uses same system as daelin's star spells. If thats the case the rules for arcane competition says not copies from older spells and no usement of spell systems made by different people.
Still the spells are nice, i give them 4/5
Still the spells are nice, i give them 4/5
Ok, here's the description
Seal of Blood: Single target friendly unit
when attacked by melee enemy, a unit with seal of blood will steal the attacker's life. The amount is based on the damage taken. The attacker will get damage equal to amount of the life that was stolen.
Celestial Star: (on Screen shot) calls a waves of holy star light, which will increase armor and regeneration of friendly non-undead unit by 1 each wave. So they will get bonus armor +1 for first channel, +2 armor 1 sec. after, +3 armor 1 sec after that, +4, +5, so on...
Charm Arrow: gives a chance to charm enemy non hero unit with arrow attack, has autocast system.
Gives me credit if you use any of them on your map.
Please gives me comment and rate it.
Seal of Blood: Single target friendly unit
when attacked by melee enemy, a unit with seal of blood will steal the attacker's life. The amount is based on the damage taken. The attacker will get damage equal to amount of the life that was stolen.
Celestial Star: (on Screen shot) calls a waves of holy star light, which will increase armor and regeneration of friendly non-undead unit by 1 each wave. So they will get bonus armor +1 for first channel, +2 armor 1 sec. after, +3 armor 1 sec after that, +4, +5, so on...
Charm Arrow: gives a chance to charm enemy non hero unit with arrow attack, has autocast system.
Gives me credit if you use any of them on your map.
Please gives me comment and rate it.