Divine Shield - Pretty simple. No offense, but nothing special at all. And yeah, it's good that you figured out the buff stuff. Took me awhile when I first made a buff spell in JASS as well.
I know,it is the simplest spell i've ever made,but i sill like it,i think is a nice idea!
Volcano Bash - You simulated Bash, in a pretty nice manner, by making the dummy unit attack the target and through that, no longer have to create a secondary trigger. However, keep in mind that there might be a difference between the moment when the projectile of the caster hits the target, and the projectiles bashing it. HOWEVER, another problem comes when the target becomes invulnerable while the projectiles are heading towards it. Try to avoid these stuff and it will be really nice.
I still wonder what will happen if the target becomes imba while missiles are on the fly ?
i think that he wont take damage . . . am i wrong?
so maybe i'll have to wait some time then launch the stuff, but i dont see that i will make that change,the spell looks preety ok to me. )
Holy - Ok, this is definitely a complicated spell, and heavily bugged. I'm not going to look over the code, pretty long and pretty late here . However, I can tell you that the heavy bug I noticed is that the drain life continues to give life to the caster even when the light balls go away. And moreover, the drain also works on other units than the caster. If you really intended it, sorry! But yeah, it is really nice. Sounds like the Arcane Pyramid though (Blade.dk) but still nice.
It takes a lot of time to build,anyway,the dummies are not supposed to give life to he caster unit!!! the heros are healed by a trigger which is not supposed to let them die.
I have made many tests with holy and i didnt found any serious bug with it.
And as for Arcane Pyramid,i knew someone would say something about that,they are similar,but i am not the guy who will copy spells from the others.
Although they have different coding structure and ( i think that ) holy is longer (in line #) than arcane pyramid.
thanks anyway!
EDIT : about Powerbash. i have a question.
is attacking a unit is faster than casting an ability into it? if so i will make the unit's missile the volcano stuff, and
add a bash with 100% chance of sucess . . .