Ok, not that original, guys. I tested the map and IMO since you praised it so much, I expected something 10 times better. It's good dude, but I am being realistic.
1. Compile a spell in a single trigger, do not split it in two or even three triggers.
2. Share Essence
Initially I thought you would make it through a better method. Guess I was wrong! The way you make buff spells is not the best. You use a timer, to remove the effects of the spell, instead of using a loop, no handlers, wait until the unit doesn't have the buff anymore, and then remove it. Here is the structure I use:
loop
exitwhen GetUnitAbilityLevel(target, BUFF_RAW_CODE)
call TriggerSleepAction(0.30)
endloop
It will not be 100% exact, but it will work and will not require handlers. Btw, Pause timers before destroying them, or else there may be the slight possibility that even though they are destroyed, they keep running. Blizzard Bug!
I personally don't use locals conditions. That is because you can't nullify them, since you return the whole condition. But not 100% sure about this, I'll have to test it.
The way you made the effect can cause serious problems! EVENT_PLAYER_UNIT_ATTACKED is enabled before the unit attacks, so it can be abused. Abusing it can cause the creation of a lot of local triggers in Trig_ShareEssenceEV_Actions, resulting in huge leaks. Triggers, when leaking, consume a lot of memory!
Avoid BJ functions. I noticed only a couple of them. IsUnitDeadBJ() can be replaced with GetWidgetLife()<=0.
3. Suffering - quite the same problems. Not much to add... Simple spell in my opinion.
4. LifeMartir - Pretty neat spell, but not great either.
5. Healing Cone - This is the sole spell which is truly worth downloading the pack. I like it! Very nice, good for an ultimate (well, not very good in melee but what the hell, screw melee). I'm a little lazy to check the code, it's huge!
Mediocre pack, in my opinion, close to good, because of Healing Cone. It's good to see people posting JASS spells. Don't give up, you're getting really good!
~Daelin
thats why i just posted it, i want to learn as i make them.. as you can see its my second spell set ever, and you really cleared it for me now.. ty.. btw, can you remove a buff by calling RemoveUnitAbility(unit,BUFF_RAW_CODE)? that sounds great! And thank you for the tips such as not to use BJ functions, pause timer, ..
