cool idea but the 3 soul spells arent really impressing. The soul theft spell is well done though so 4/5^^
Comments
22
Nice U.V thanks for working on our map, thanks a lot dude this spell rox as well 5/5!! 
humm, i like it but i have seen some better spells... so 4/5
Its ok U.V i've seen better work from you. 4/5
Now that its fixed this is awesome, still some minor bugs, but for a single player map this is pure gold 
I'd know how to fix the gold/exp part, but I don't have any time now, if u want I'll post the fixed trigger here later.
but i WAS right about the trigger not being the cause of the major lag.
and i dont know the relativity rules (or whatever) of gold and exp giving.
EDIT:
oh and sorry about the 'leak' thing. now i know what you were talking about and youre right (in the uncleared sound case). o well
and i dont know the relativity rules (or whatever) of gold and exp giving.
EDIT:
oh and sorry about the 'leak' thing. now i know what you were talking about and youre right (in the uncleared sound case). o well
I don't say that one spell like this would cause noticeable lagg, but when you have many of them in your map and all have such leaks, it will get unplayable after some time.
Ohh and since the lagg is fixed, try making the soul strike ability give exp and gold and I'll rate it a 5, I really like your spells even if they have/had some "bugs"!
Ohh and since the lagg is fixed, try making the soul strike ability give exp and gold and I'll rate it a 5, I really like your spells even if they have/had some "bugs"!
U.V. MasterGT4 is right your triggers do leak a large portion of memory. Wont be noticeable in such a small map when its only used a few times. But just cast that spell 50000 times in 1 game and you will lagg yourself out because of it.
And that loop of 0.01 second you know that that doesnt work on b.net right? Because lowest you can go is like 0.10 seconds it wont be able to handle lower. So your spell will not be the same on b.net as they are in single player.
And that loop of 0.01 second you know that that doesnt work on b.net right? Because lowest you can go is like 0.10 seconds it wont be able to handle lower. So your spell will not be the same on b.net as they are in single player.
First thing, what the fuck do you always talk about loops? I didn't say anything about loops and loops also don't leak if the functions in them don't leak.
I'm talking about your functions, for example:
You leak one point, there's a point created at the position of the target every time you use the function, but it's never destroyer, and since you use really many functions like that it will leak after using the ability really many times! For example in an AOS like map.
And another thing I noticed: Your Soul Strike spell doesn't give exp/gold.
And your spells aren't in any way multi-instanceable.
Think about what I said...
Ohh and you shouldn't say things like "i know triggers better than you!" when you don't know me!
I'm talking about your functions, for example:
Sound - Play DevourMagic <gen> at 100.00% volume, located at (Position of (Target unit of ability being cast)) with Z offset 0.00You leak one point, there's a point created at the position of the target every time you use the function, but it's never destroyer, and since you use really many functions like that it will leak after using the ability really many times! For example in an AOS like map.
And another thing I noticed: Your Soul Strike spell doesn't give exp/gold.
And your spells aren't in any way multi-instanceable.
Think about what I said...
Ohh and you shouldn't say things like "i know triggers better than you!" when you don't know me!
it doesnt lag now, so please lay off!
thoes triggers are important for when someone uses these spells in an actual game where other things may affect the buffed units if the triggers dont attend to them.
do you know how many loops like these are there in the WarCraft Engine????? when a group of 12 archers shoot a group of necromancers, or when a unit is slowed and had been colored blue after being hit by a frost nova?? i wont bother to estimate.
this is how things are done in spell making.
and about you being right - no, you're wrong!
i just tried to see if it makes any difference, and it doesnt! you can change it back the way it was and it wont lag. want to know why it lagged?
cause i made the buff of the spell to last 3600 seconds(!), and after stealing too many souls it lags. now theres no buff hance no lag. liked ive said, the problem was in the base of the spell and not my triggers.
once again you're wrong.
EDIT:
about the mana regina, you're welcome to check most of my spell maps - ive used the same trigger and it doesnt lag. give it up.
thoes triggers are important for when someone uses these spells in an actual game where other things may affect the buffed units if the triggers dont attend to them.
do you know how many loops like these are there in the WarCraft Engine????? when a group of 12 archers shoot a group of necromancers, or when a unit is slowed and had been colored blue after being hit by a frost nova?? i wont bother to estimate.
this is how things are done in spell making.
and about you being right - no, you're wrong!
i just tried to see if it makes any difference, and it doesnt! you can change it back the way it was and it wont lag. want to know why it lagged?
cause i made the buff of the spell to last 3600 seconds(!), and after stealing too many souls it lags. now theres no buff hance no lag. liked ive said, the problem was in the base of the spell and not my triggers.
once again you're wrong.
EDIT:
about the mana regina, you're welcome to check most of my spell maps - ive used the same trigger and it doesnt lag. give it up.
Sry but your triggers DO leak, may be that something else leaks more but your triggers leak serveral points, player groups, and more!
Ohh and I know some of your changes, you changed the mana regain trigger for example!
And the Soulless trigger to remove unit when it's dead!
So I AM RIGHT, it was a trigger leak!
Ohh and I know some of your changes, you changed the mana regain trigger for example!
And the Soulless trigger to remove unit when it's dead!
So I AM RIGHT, it was a trigger leak!
hahahaha!!
the bug is fixed!! i and it wasnt in the triggers!!!
want to know what is was? i wont tell, to make you feel stupid
@MasterGT4:
sorry, but you were wrong!
and sorry about the fight but you really pissed me off back there, let there be peace!
EDIT:
the fixed spell is now up and running!
ENJOY!!
the bug is fixed!! i and it wasnt in the triggers!!!
want to know what is was? i wont tell, to make you feel stupid
@MasterGT4:
sorry, but you were wrong!
and sorry about the fight but you really pissed me off back there, let there be peace!
EDIT:
the fixed spell is now up and running!
ENJOY!!
May be, BUT your triggers leak, too!
Ohh and the download doesn't work anymore, too!
Ohh and the download doesn't work anymore, too!
now listen up,
first of all i did not flame no one.
secondly ive written, and you're welcom to read again:
THE MAP LAGS WITHOUT MY TRIGGERS!!
thank you
first of all i did not flame no one.
secondly ive written, and you're welcom to read again:
THE MAP LAGS WITHOUT MY TRIGGERS!!
thank you
If you want, I can fix it for you...
And why do you post such things as testings, I exactly know what leaks in your trigger, however I'd need custom script or Jass to fix that leaks! And STOP FLAMING ME YOU ******* OK? Your triggers DO leak! And if you think they don't then you know NOTHING about memory leaks or triggers!
And why do you post such things as testings, I exactly know what leaks in your trigger, however I'd need custom script or Jass to fix that leaks! And STOP FLAMING ME YOU ******* OK? Your triggers DO leak! And if you think they don't then you know NOTHING about memory leaks or triggers!
my looping triggers are by no-mean useless!
not only its not the first time i use such triggers in my spells and haven't seen a problem like this before, but i've also TURNED OFF all looping triggers that are not being used.
after checking the spell a few times ive noticed that in time the lag reduces, and that the lag does not increace if the spell cannot be cast (targeting undead or have 3 souls). thus my guess is that problem is with the soul-effect units, that maybe are not properly removed from the game or something.
EDIT:
ive started to run a debug operation and here are my findings:
-the looping trigger are NOT the cause of lag!! ive run the spell without ANY of them and it still lags.
-the effect units are also not the cause, for the same reasons.
REPORT II:
final test - i've tried to cast the spell WITHOUT the primary spell trigger, and it still lags!
conclusion: there's something wrong with the spell base, not my triggers! so dont give me that 'your triggers leak' cr*p! i know triggers better than you!
i will try using a different spell base, until then im taking off the map.
not only its not the first time i use such triggers in my spells and haven't seen a problem like this before, but i've also TURNED OFF all looping triggers that are not being used.
after checking the spell a few times ive noticed that in time the lag reduces, and that the lag does not increace if the spell cannot be cast (targeting undead or have 3 souls). thus my guess is that problem is with the soul-effect units, that maybe are not properly removed from the game or something.
EDIT:
ive started to run a debug operation and here are my findings:
-the looping trigger are NOT the cause of lag!! ive run the spell without ANY of them and it still lags.
-the effect units are also not the cause, for the same reasons.
REPORT II:
final test - i've tried to cast the spell WITHOUT the primary spell trigger, and it still lags!
conclusion: there's something wrong with the spell base, not my triggers! so dont give me that 'your triggers leak' cr*p! i know triggers better than you!
i will try using a different spell base, until then im taking off the map.
I have to check this out
*edit* wow that's laggy.
on my 866, if I capture more than one sould, I can't play. I have to alt+x out and that takes about 10 seconds.
*edit* wow that's laggy.
on my 866, if I capture more than one sould, I can't play. I have to alt+x out and that takes about 10 seconds.
You're joking right?
Your triggers leak immensely and some are inefficient...
It's easy to fix the leaks but I can't tell you now because there are simply so many leaks in the triggers!
Your triggers leak immensely and some are inefficient...
It's easy to fix the leaks but I can't tell you now because there are simply so many leaks in the triggers!
Awesome. If it werent for the lag this would be perfect.
EDIT: Reason for lag is probably cus of the many periodic triggers you have, most of which are useless.
EDIT: Reason for lag is probably cus of the many periodic triggers you have, most of which are useless.
Wow... intense lag, I'm on a 3 GHz and it hurt.
EDIT:
Please ignore the following note, as everything is fixed now.
IMPORTANR NOTE:
For simply UNKNOWN reasons the map begins to lag after stealing a certain number of souls.
I've tried checking dozens of times what might cause that and have found nothing.
I will try to consult Darky28 or Vexorian and ask for their help, but should I never get their attention, this is all
I can give you.
My sincerest apologies
Please ignore the following note, as everything is fixed now.
IMPORTANR NOTE:
For simply UNKNOWN reasons the map begins to lag after stealing a certain number of souls.
I've tried checking dozens of times what might cause that and have found nothing.
I will try to consult Darky28 or Vexorian and ask for their help, but should I never get their attention, this is all
I can give you.
My sincerest apologies