First off having 2.7 Quintillion different combinations does mean that 1 out of 2.7 quintillion users who type a random string will get the correct combination. However, the numbers are quite a bit less, because each portion of the code has several variations that work, so the numbers are much less than 1 out of 2.7 quintillion will crack it. You have to divide that number multiple times over to get the accurate ratio like that. The code includes parts of the username unique to each user, so the combinations are even fewer. Here is a rough estimate of the typing random integers would look like: 1,726,051,000. Also, if a user is able to crack any part of the code, that number is a lot less. If I was to put the possible combinations of 1,000,000 if any part of the code was cracked... it would make the rest of the code easier to crack. Im not sure if that made any sense, but thats how it would work

.
In addition, this doesn't add at all to the length of the code (what seems to be one of your biggest complaints). I don't see how this is a complaint of my trigger.
0-9999, you can do a lot with that. Saving gold and wood I see what your saying. However, all you do is divide that number by 100, and then multiply it by 100, and you can get a pretty acurate amount of gold the user had when loading.
E.G: Gold = 839,616. 839,616/100= 8396 (the game auto rounds down). When loading, multiply it by 100. you get 839600. Yes, you lost 16 gold, but when you are dealing with that much, does 16 really make much of a difference? Same Goes with Hero Experience. Your argument is a valid one, though, and I will try to increase the numbers.
All you have to do is mix up the variables combinations and values a bit to make it unique. If someone did use this code have, they just need to change a some values around (not even all of them, just 1/2 of Z or so), and possibly re-arrange part of the code. Having access to this code doesn't do anything if people jumble up this code a bit. So, you know how it works... good luck trying to crack it.
Safer, Safer, Safer... I rather have a code that is 17 Digits long and nearly un-crackable than a 10 digit code that is less un-crackable. Again, you make a very valid argument, but I don't think people are really going to care about an extra few characters (although some would). I will absolutly look at your JASS script, I have a basic knowledge about JASS, so It won't be too scary looking. Thanks for all your comments; it's nice to get criticism here and there... thats how you make things better

.