Spin Toss is an ability used for the Tauren Chieftan Hero model. Basicaly what happens, is the tauren swings and grabs a unit with his axe, spins them around a few times, and then hurls them in the air, bouncing a few times and dealing damage.
TY very much Vexorian. I am new at the JASS thing, as I said this was my first Spell, and my first real attempt at implementing JASS. All the things you pointed out really helped. This ability as it is does leak tremendously, I tried to do what I could to stop some of the leaks with what I understood.
I used the "SELL_CAST" event because it messes the timing up when the unit does his spell animation, makes it look weird and delayed. Although I never did the Start Effect event, I only tried the finished casting one.
I didn't know about those other animation things either, like you could call it from an index, I was just going off of what the preview screen said in WE. I like using the death animation because it calls their death sound specificly to that unit and the right kind of blood, I might try to make a short sleepaction and reset anim just long enough to get the "death" effects, but not long enough for it to disapear.
I used globals so I could pass it through to the other functins easier. Come to think of it, I could just pass those locals through as parameters huh? that would make it multi-instanceable.
and, how do I reuse a timer? I thought the only way to stop the timer was to destroy it, and if i destroyed it, I didn't think I could use it again.
again thank you very much, this is how I learn = D
EDIT: I can't pass parameters to functions used by my timer = /, or if I can, I don't know how.
What the spell does: (25/30) - Original and nice stuff, spining and throwing it away
Code: 12/20 : - Wrong Event ( SPELL_CAST instead of SPELL_EFFECT ) , allows abuse. - I am not a fan of using the death animation on these spells, mostly because it doesn't work with some models, for example in this map the obsidian statue, the steam tank and the wisp. - It is in JASS but uses global variables and it seems as if it was GUI originally and with some added locals. - uses "Attack - 1" for the animation, which will sometimes fail, making the spell look odd, for this he should have used SetUnitAnimationByIndex - Certain variables could be resused instead of making other ones (for example the timer locals)
Efficiency: 10/30 - Leaked Memory: 1076 KB per cast. - Weak point, should not use Blizzard.j functions that should be replaced with common.j ones. And should take care of locations(points) , setting the variables to null isn't enough, should also call RemoveLocation on them.
Multi instancibility: 0/10 - Another weak point, no multi instancibility at all.
Eye Candy: 9/10 - It is nice to see the spell in action
Total 56/100 : 3/5; Without leaks and with multi instancibility it would have been perfect.
Edit:Only problems were the bounces seemed to happen a split second or more to late. Working with death animations can be tricky which explains some units dissapearing during the progress. Also after the ability is finnished maybe reset the target's animation (it stays in the death animation until something disturbs it). I liked how it damages units that are in the way when the unit gets thrown too. If you could control where it is throw (like into a group of enemies) it would be really kool. Maybe you could manually control the spinning and after x amout of time he throws it with distance based on how many times you spin into the direction that your facing at throwing point, but maybe not just a thought.
yeah, I have the movement of the unit being tossed and the special effects / damage running simultaneously in 2 different functions, so it doesn't always match up quite right. Another thing that I can't seem to get past, is rotating the unit faster, that was as fast as I could get him to spin, I tried many different methods too. I'll update the spell before June 1st that is for sure = )
Wow. Very nice spell. Not only well made but really fun to use. I would give you a 4/5 for Incentive to make this perfect but I like it too much already
Oh im going to make it smoother with more fixes, my main concern right now, is being able to use the spell and have it toss the unit in a consistant direction. I "generaly" have it going in the direction you face when you start the spell, but my trigger is dependany on SleepActions, so the timing isn't always right. I naddition to that, i want to make it look a little more smooth on the toss. Thanks everyone for your comments = )
(PS. Everyhting I used in this spell I used form Daelin's tutorial on JASS, It is simply amazing, read his tutorial. It was pretty much the only resource I used, and of course Kattana's Jass editor = ).
Wow. Very nice spell. Not only well made but really fun to use. I would give you a 4/5 for Incentive to make this perfect but I like it too much already. 5/5 good work ..................................................... Edit:Only problems were the bounces seemed to happen a split second or more to late. Working with death animations can be tricky which explains some units dissapearing during the progress. Also after the ability is finnished maybe reset the target's animation (it stays in the death animation until something disturbs it). I liked how it damages units that are in the way when the unit gets thrown too. If you could control where it is throw (like into a group of enemies) it would be really kool. Maybe you could manually control the spinning and after x amout of time he throws it with distance based on how many times you spin into the direction that your facing at throwing point, but maybe not just a thought.
first spell??? Pros: wow...this is so goddamn amazing!!! i could spend hours upon hours of just throwing a catapult around! very funny, very unique, and very handy and a good demonstration of your Jassing Skills...
Cons: sometimes when you cast this spell on a certain type of unit, such as destroyers, the unit just dissapears, doesnt really matter though =)
Overall Grade: 5/5, cause im sure the destroyer glitch can be fixed out
AWSOME!!!!!!!!!!!!!